Fix Paraglide locale links to use resolve#990
Closed
samuelstroschein wants to merge 2 commits intosveltejs:mainfrom
Closed
Fix Paraglide locale links to use resolve#990samuelstroschein wants to merge 2 commits intosveltejs:mainfrom
samuelstroschein wants to merge 2 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c157e9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
|
the fix is also here |
Member
|
CI does not seem to be entirely happy yet, not too sure why yet. But we will have to check this at a later point in time |
Contributor
|
@jycouet This can be closed now. |
Contributor
|
#1049 fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes opral/paraglide-js#638
Summary
resolvefrom$app/pathsin the Paraglide addon-generated+layout.svelteresolve(localizeHref(...))Why
The current generated locale switcher uses raw
href={localizeHref(...)}links, which triggers the Svelte ESLint rulesvelte/no-navigation-without-resolvein fresh Paraglide-enabled SvelteKit projects.Verification
bennajah/svelte-demoresolve(localizeHref(...))fixes the lint error